Remove optimistic Concierge thinking indicator by chiragsalian · Pull Request #88747 · Expensify/App

chiragsalian · 2026-04-24T18:10:44Z

HOLD till,

are live.

Explanation of Change

Removes the client-side optimistic "Concierge is thinking..." indicator entirely. Backend is now the sole source of truth for whether to show the indicator.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/621231
PROPOSAL:

Tests

Setup,

Needs to have an AM assigned to the domain. When creating an account, during onboarding select - manage and size of 11-50. An AM should be auto assigned to you.

Manual verification (combined with the backend PRs):
Concierge DM

Open a Concierge DM.
Send a message like "hi, can you tell me a joke". Confirm you see "Concierge is thinking" (might take 10-20s to show up)
Once done confirm Concierge replied with a joke. This is a response from AZ.
Then send a message like,

Hi Concierge, i really dont like AI. Can you escalate this chat of mine to a human.
To the human, this is an internal test message, can you reply with "test me" so i can verify Concierge routing logic?

Confirm you see "Concierge is thinking" (might take 10-20s to show up)
Wait 5mins for an agent response. If you don't get one ping me (chirag) and i'll send you an agent response.
This can only be tested within 30mins of an agent response so do this soon after. Send another message like Another test message to test routing, please respond with "test me two".
Wait 10-20s, confirm you didnt see "Concierge is thinking", because the chat went directly to human agent.

Admins room chat

Open admins room. This steps before will only work if there is an AM assigned. If an AM is assigned you'll see a message like this at the top "Hey there, I'm your Expensify setup specialist." from someone other than Concierge.
Send a message like "hi, can you tell me a joke". Confirm you see "Concierge is thinking" (might take 10-20s to show up).
Once done confirm Concierge replied with a joke. This is a response from AZ.
Then send a message like,

Hi Concierge, i really dont like AI. Can you escalate this chat of mine to a human.
To the human, this is an internal test message, can you reply with "test me" so i can verify Concierge routing logic?

Confirm you see "Concierge is thinking" (might take 10-20s to show up)
Wait 5mins for an agent response. If you don't get one ping me (chirag) and i'll send you an agent response.
This can only be tested within 30mins of an agent response so do this soon after. Send another message like Another test message to test routing, please respond with "test me two".
Wait 10-20s, confirm you didnt see "Concierge is thinking", because the chat went directly to human agent.

Verify that no errors appear in the JS console

Offline tests

The optimistic indicator was already gated on !isOffline; offline behavior is unchanged — messages queue normally, no indicator renders until online and server sends a label.

QA Steps

Setup,

Needs to have an AM assigned to the domain. When creating an account, during onboarding select - manage and size of 11-50. An AM should be auto assigned to you.

Same as the manual verification above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Copilot

Pull request overview

Removes the client-side “Concierge is thinking…” optimistic indicator so the UI shows AgentZero processing state only when the backend provides a processing label.

Changes:

Removed the kickoffWaitingIndicator optimistic flow from AgentZeroStatusContext (including localization dependency and timeout logic).
Stopped triggering the optimistic indicator on message send (useComposerSubmit).
Updated unit tests to reflect server-driven-only processing state.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/unit/AgentZeroStatusContextTest.ts	Removes tests/mocks for the optimistic indicator and updates expectations to server-label-only behavior.
src/pages/inbox/report/ReportActionCompose/useComposerSubmit.ts	Stops calling the removed `kickoffWaitingIndicator` action on submit.
src/pages/inbox/AgentZeroStatusContext.tsx	Deletes optimistic state/actions and derives processing/label state solely from the server-provided indicator.

Comments suppressed due to low confidence (1)

src/pages/inbox/AgentZeroStatusContext.tsx:103

This component updates state during render (setPrevServerLabel / setReasoningHistory inside an if at the top level). Even though the condition prevents an infinite loop, setting state during render is an anti-pattern in React and can produce warnings/unpredictable behavior with concurrent rendering. Move this logic into a useEffect that runs when serverLabel changes (and clear reasoningHistory there when transitioning truthy → falsy).

    // Clear reasoning when processing ends (server label transitions from truthy → falsy)
    const [prevServerLabel, setPrevServerLabel] = useState(serverLabel);
    if (prevServerLabel !== serverLabel) {
        setPrevServerLabel(serverLabel);
        if (prevServerLabel && !serverLabel && reasoningHistory.length > 0) {
            setReasoningHistory([]);
        }
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

melvin-bot · 2026-04-27T20:34:05Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chiragsalian · 2026-04-27T20:35:21Z

Ready for review. You won't be able to test the full PR since it requires web-e and auth to be deployed test it fully. But you can test that we've removing optimistic setting of "Concierge is thinking.."

trjExpensify

Makes sense 👍

ahmedGaber93 · 2026-04-30T02:08:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

ahmedGaber93 · 2026-04-30T02:53:10Z

But you can test that we've removing optimistic setting of "Concierge is thinking.."

It has been removed and works as expected. I’ll run a final test after the BE PR is deployed.

codecov · 2026-05-01T23:17:42Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
...components/Search/SearchRouter/useAskConcierge.tsx	`72.72% <ø> (ø)`
src/libs/actions/Report/index.ts	`69.70% <ø> (+0.26%)`	⬆️
src/pages/inbox/AgentZeroStatusContext.tsx	`98.38% <100.00%> (-0.54%)`	⬇️
...ox/report/ReportActionCompose/useComposerSubmit.ts	`50.00% <ø> (-0.99%)`	⬇️
... and 8 files with indirect coverage changes

setOptimisticStartTime was deleted along with the optimistic indicator, but the kickoff useEffect that called it remained, breaking typecheck. The kickoff path's only purpose was starting the optimistic timer, so the entire chain (Onyx key, setter/clearer in Report, set call from useAskConcierge) is now dead and removed.

chiragsalian · 2026-05-01T23:36:42Z

BE code is live. Code should be ready for review.

chiragsalian added 2 commits April 24, 2026 11:06

Remove optimistic Concierge thinking indicator from App

eb4fde9

Drop optimistic indicator tests

f9e4876

melvin-bot Bot assigned chiragsalian Apr 24, 2026

prettier

4794097

chiragsalian changed the title ~~Remove optimistic Concierge thinking indicator~~ [HOLD] Remove optimistic Concierge thinking indicator Apr 24, 2026

chiragsalian requested a review from Copilot April 24, 2026 22:10

Copilot started reviewing on behalf of chiragsalian April 24, 2026 22:10 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread src/pages/inbox/AgentZeroStatusContext.tsx Outdated

Update AgentZeroStatusGate doc comment to mention admins rooms

dc7b4a8

chiragsalian marked this pull request as ready for review April 27, 2026 20:33

chiragsalian requested review from a team as code owners April 27, 2026 20:33

melvin-bot Bot requested review from ahmedGaber93 and trjExpensify and removed request for a team April 27, 2026 20:34

melvin-bot Bot removed the request for review from a team April 27, 2026 20:34

trjExpensify previously approved these changes Apr 28, 2026

View reviewed changes

chiragsalian changed the title ~~[HOLD] Remove optimistic Concierge thinking indicator~~ Remove optimistic Concierge thinking indicator May 1, 2026

Merge branch 'main' into chirag-AZ-indicator-changes

917981c

chiragsalian dismissed trjExpensify’s stale review via 917981c May 1, 2026 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove optimistic Concierge thinking indicator#88747

Remove optimistic Concierge thinking indicator#88747
chiragsalian wants to merge 6 commits intomainfrom
chirag-AZ-indicator-changes

chiragsalian commented Apr 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

chiragsalian commented Apr 27, 2026

Uh oh!

trjExpensify left a comment

Uh oh!

ahmedGaber93 commented Apr 30, 2026

Uh oh!

ahmedGaber93 commented Apr 30, 2026

Uh oh!

codecov Bot commented May 1, 2026 •

edited by github-actions Bot

Loading

Uh oh!

chiragsalian commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chiragsalian commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

chiragsalian commented Apr 27, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Apr 30, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Apr 30, 2026

Uh oh!

codecov Bot commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chiragsalian commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chiragsalian commented Apr 24, 2026 •

edited

Loading

codecov Bot commented May 1, 2026 •

edited by github-actions Bot

Loading